Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codeAction): <Plug> mappings for confirm and quit #624

Closed
wants to merge 2 commits into from

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Dec 18, 2024

Closes #622

@mrcjkb mrcjkb changed the title feat(codeAction): <Plug> mappings for confirm and quit feat(codeAction): <Plug> mappings for confirm and quit Dec 18, 2024
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb marked this pull request as draft December 18, 2024 19:48
@mrcjkb mrcjkb force-pushed the mj/push-wsxvlpnyzzpo branch from caadae7 to 360d2cc Compare December 18, 2024 20:10
@mrcjkb mrcjkb force-pushed the mj/push-wsxvlpnyzzpo branch from 360d2cc to 95315b0 Compare December 18, 2024 20:11
@mrcjkb
Copy link
Owner Author

mrcjkb commented Dec 18, 2024

Note to self for when I pick this up again:

This is blocked on the following issue:

  • If a user defines a keymap (e.g. h and l for quit and confirm), without specifying the buffer, the default mapping will be overridden. A potential solution could be to invoke a User autocommand with the buffer ID in the data table.

Ideally, (neo)vim should fall back if a <Plug> mapping is not defined. But this doesn't appear to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable keymap for the codeAction window
1 participant